[XML-DEV Mailing List Archive Home] [By Thread] [By Date] [Recent Entries] [Reply To This Message]

Re: Allowed PEReference usages

• To: "James Clark" <jjc@j...>
• Subject: Re: Allowed PEReference usages
• From: "Karl Waclawek" <karl@w...>
• Date: Thu, 3 Jul 2003 00:04:43 -0400
• Cc: "Arjun Ray" <aray@n...>, <xml-dev@l...>
• References: <Law11-F113g1WTp6AVj00032e97@h...> <6034gv8dicubr1s23gh0vrd0g6bicv19hs@4...> <001101c340f5$b10250b0$027ca8c0@karl> <3F0390CB.5010303@j...>

> >>| Assuming that it is possible to declare a PE named 'percent' with a 
> >>| literal '%', is the following allowed?
> >>| 
> >>| <!ENTITY %percent; x "value">
> >>
> >>Permissible in SGML - should be okay in XML.
> > 
> > 
> > Accepted by MSXML4.
> > 
> > Rejected by 
> > - Expat: "Unclosed token" 
> >   (it seems Expat considers % followed by a name one token)
> 
> That's a bug in expat I think.  Try this (tested with expat 1.2):
> 
> --- xmltok/xmltok_impl.c        20 Oct 2000 04:17:27 -0000      1.42
> +++ xmltok/xmltok_impl.c        3 Jul 2003 02:08:48 -0000
> @@ -881,7 +881,7 @@
>                          const char **nextTokPtr)
>   {
>     if (ptr == end)
> -    return XML_TOK_PARTIAL;
> +    return -XML_TOK_PERCENT;
>     switch (BYTE_TYPE(enc, ptr)) {
>     CHECK_NMSTRT_CASES(enc, ptr, end, nextTokPtr)
>     case BT_S: case BT_LF: case BT_CR: case BT_PERCNT:

Seems to work for current Expat too, so I committed your patch already. 
This is the first Expat bug found in a long time.

Karl

• References:
  • Re: Allowed PEReference usages
    • From: Arjun Ray <aray@n...>
  • Re: Allowed PEReference usages
    • From: "Karl Waclawek" <karl@w...>
  • Re: Allowed PEReference usages
    • From: James Clark <jjc@j...>

• Prev by Date: Re: Relax NG annoyances
• Next by Date: Re: FW: Relax NG annoyances
• Previous by thread: Re: Allowed PEReference usages
• Next by thread: Re: Allowed PEReference usages
• Index(es):
  • Date
  • Thread