[XML-DEV Mailing List Archive Home] [By Thread] [By Date] [Recent Entries] [Reply To This Message]

RE: code challenge

• To: "Paul Brown" <prb@f...>,"Xml-Dev" <xml-dev@l...>
• Subject: RE: code challenge
• From: "Danny Ayers" <danny666@v...>
• Date: Sat, 10 Aug 2002 09:26:30 +0200
• Cc: "Jeff Lowery" <jlowery@s...>
• Importance: Normal
• In-reply-to: <7D365016E308F44EACB6ADB51CBD69043282A2@s...>

>I'm a C programmer at heart.  You see a Java object, I see a pointer...

I see far too many NullPointerExceptions!

>> 05>     if (next.getNodeType() == Node.ELEMENT_NODE) {
>> 06>       getElements(e,l).add(e);
>> 07>     }
>
>Well, this won't work either (it should be adding next, not e),
>but I have the excuse of having written the code in my phone's
>email client.

I put a milk carton in the oven the other day...

>This will work (and is shorter, although I added some linebreaks
>for style purposes):
>
>  public List getElements(Document d) {
>    return getElements(
>      d.getDocumentElement(),
>      new ArrayList(Collections.singleton(d.getDocumentElement()))
>    );
>  }
>
>  private final List getElements(Node e, final List l) {
>    for (Node next = e.getFirstChild();next != null;next =
>next.getNextSibling()) {
>      if (next.getNodeType() == Node.ELEMENT_NODE) {
>        getElements(next,l).add(next);
>      }
>    }
>    return l;
>  }
>
>That said, I'm assuming that we can do a Riserva from 1997 or 1998?

Given the stylish use of the singleton, I suppose so (sheesh! you're
probably talking 4 or 5 euro).

Cheers,
Danny.

• References:
  • RE: code challenge
    • From: "Paul Brown" <prb@f...>

• Prev by Date: Re: XHTML 2.0 and the death of XLink and XPointer?
• Next by Date: Re: XHTML 2.0 and the death of XLink and XPointer?
• Previous by thread: RE: code challenge
• Next by thread: Is it time for the 80/20 thread yet?
• Index(es):
  • Date
  • Thread