[XML-DEV Mailing List Archive Home] [By Thread] [By Date] [Recent Entries] [Reply To This Message]

RE: code challenge

• To: "Jeff Lowery" <jlowery@s...>,"Xml-Dev" <xml-dev@l...>
• Subject: RE: code challenge
• From: "Danny Ayers" <danny666@v...>
• Date: Fri, 9 Aug 2002 11:29:34 +0200
• Importance: Normal
• In-reply-to: <D60D8F448216D611A21A00508B62B5BC5CD5@e...>

>First, get rid of the global, like so:
>
>>
>>
>*  public List getChildren(Element element) {
>>
>*     List elements = new ArrayList();
>>     elements.add(element);
>>
>>     Node child;
>>     Node next = (Node) element.getFirstChild();
>>     while ((child = next) != null) {
>>         next = child.getNextSibling();
>>             if (child.getNodeType() == Node.ELEMENT_NODE) {
>>                 getChildren((Element) child);
>>             }
>>         }
>*     return elements;
>> }

Unfortunately that won't work - the list is created afresh on every call, so
will only contain the last element encountered.

>Next, get rid of all the carriage returns.

;-)

Paul Brown sent me a way of getting rid of the global that should work, just
lugging the list along for every call :

public ArrayList getElements(Document d) {
  return getElements(d.getDocumentElement(),new ArrayList());
}


01> private ArrayList getElements(Element e, ArrayList l) {
03>   Node next = e.getFirstChild();
04>   do {
05>     if (next.getNodeType() == Node.ELEMENT_NODE) {
06>       getElements(e,l).add(e);
07>     }
08>   } while ((next = next.getNextSibling()) != null);
09>   return l;
10> }



>That knocks it down to about one line of code.  I like my Chianti very dry,
>thank you.

Me too!

Thanks,
Danny.

• References:
  • RE: code challenge
    • From: Jeff Lowery <jlowery@s...>

• Prev by Date: FYI: Edsger Wybe Dijkstra, 11 May 1930 -- 6 August 2002
• Next by Date: RE: code challenge
• Previous by thread: Re: code challenge
• Next by thread: RE: code challenge
• Index(es):
  • Date
  • Thread