[XML-DEV Mailing List Archive Home] [By Thread] [By Date] [Recent Entries] [Reply To This Message]

Re: Genx

• To: xml-dev@l...
• Subject: Re: Genx
• From: David Tolpin <dvd@d...>
• Date: Tue, 20 Jan 2004 18:45:09 +0400 (AMT)
• In-reply-to: <400D2A09.9050206@b...>

> // for making UTF-8 strings
> > typedef unsigned char utf8Byte;

I would prefer this to be just char, the whole point behind UTF-8 is then
you don't need to know that it is it is just char *. Convertion to unsigned char *
is due to arithmetics, but arithemtics is opaque.

> // writer object
> typedef void * genxWriter;

This is C; any type typedef'ed to void * allows any other type.  I would prefer it to 
be opaque, but not void:

typedef struct GenxWriter *genxWriter;

to get error 'passing from incompatible pointer type'.

> void genxStartDocument(genxWriter w, FILE * file);

While FILE * is 'standard', it is often incovenient to use it; I would prefer
to have

void genxStartDocument(genxWriter w, char *buf, int size, void (*bytesReady)(int n,void *userData))

size is the size of the buffer, bytesReady is passed actual number of bytes available.
Much more freedom to use.

> int genxText(genxWriter w, const utf8Byte * text);
> int genxTextW(genxWriter w, const codePoint * text);

passing data in buffers oftern requires number of bytes or characters to be passed;
consider getting data from Expat and writing it to the output.

int genxText(genxWriter w, const utf8Byte * text, int nbytes);
int genxTextW(genxWriter w, const codePoint * text, int nchars);

instead?

> int genxCharacter(genxWriter w, codePoint c);

What's the use case for this?

> int genxScanUTF8(genxWriter w, const utf8Byte * s);

1) again, length. s/)/,int nbytes)/
2) what if I am reading from a stream and the last utf sequence is not read fully?


David Tolpin

• Follow-Ups:
  • Re: Genx
    • From: Joe Gregorio <joe@b...>
  • Re: Genx
    • From: Adam Turoff <ziggy@p...>

• References:
  • Re: Genx
    • From: Joe Gregorio <joe@b...>

• Prev by Date: RE: Postel's law, exceptions
• Next by Date: Re: Genx
• Previous by thread: Re: Genx
• Next by thread: Re: Genx
• Index(es):
  • Date
  • Thread