[XML-DEV Mailing List Archive Home] [By Thread] [By Date] [Recent Entries] [Reply To This Message]

RE: Possible parse() overloading bug in XMLFilterImpl

• From: Miles Sabin <msabin@c...>
• To: Elliotte Rusty Harold <elharo@m...>, xml-dev@x...
• Date: Thu, 9 Mar 2000 15:59:17 -0000

Elliotte Rusty Harold wrote,
> What I suspect it should do is:
>
>     public void parse (String systemId)
>         throws SAXException, IOException
>     {
>         parse(new InputSource(systemId));
>     }
>
> No similar constraint is given in the Java docs for
> XMLFilterImpl, which does not implement XMLReader, so maybe 
> there's a reason for these two to behave differently. But it 
> seems suspicious to me. Since XMLFilterImpl implements 
> XMLFilter which extends XMLReader, I'd expect the constraints 
> to inherit through.

No doubt about it: you're right, it's a bug and your solution
is the right one.

The XMLReader interface made a behavioural contract, and all 
it's implementers, XMLFilterImpl included must honour it, on 
pain of violating the Liskov Substitution Princlple (qv).

Cheers,


Miles

-- 
Miles Sabin                       Cromwell Media
Internet Systems Architect        5/6 Glenthorne Mews
+44 (0)20 8817 4030               London, W6 0LJ, England
msabin@c...          http://www.cromwellmedia.com/

***************************************************************************
This is xml-dev, the mailing list for XML developers.
To unsubscribe, mailto:majordomo@x...&BODY=unsubscribe%20xml-dev
List archives are available at http://xml.org/archives/xml-dev/
***************************************************************************

• Prev by Date: Re: XML over HTTP: SOAP and ...?
• Next by Date: Re: Gutenberg Project <longish>
• Previous by thread: Possible parse() overloading bug in XMLFilterImpl
• Next by thread: schema by example
• Index(es):
  • Date
  • Thread